When function createRole is called for a known role and the parameter isTeam is inconsistent with what is already stored for the known role, the function silently updates the row. The update itself is not harmful because it does not overwrite the stored isTeam, but the silence has serious impact on functions createStudent etc. which require roles to be users.
createRole should raise an exception in this case.
smurthys
commented
6 years ago
When function
createRoleis called for a known role and the parameterisTeamis inconsistent with what is already stored for the known role, the function silently updates the row. The update itself is not harmful because it does not overwrite the storedisTeam, but the silence has serious impact on functionscreateStudentetc. which require roles to be users.createRoleshould raise an exception in this case.