Some test scripts use COMMIT instead of ROLLBACK (W)

DASSL / ClassDB

An open-source system to let students experiment with relational data

https://dassl.github.io/ClassDB/

Other

8 stars 2 forks source link

Some test scripts use COMMIT instead of ROLLBACK (W) #197

Open smurthys opened 6 years ago

smurthys commented 6 years ago

Some test scripts (e.g., testHelpters.sql use COMMIT unnecessarily.

Unless absolutely necessary all test scripts should use ROLLBACK. Then, tests should forego dropping/deleting objects as part of cleanup unless dropping/deleting is part of the test.

smurthys commented 6 years ago

I recommend that as test scripts are edited/created, COMMIT statements at the end of scripts be replaced with ROLLBACK. This change will leave the DB unchanged and can greatly simplify code.