Open afig opened 6 years ago
I agree with the issue description. I feel a lone README file in any directory can just be called README.
I believe the issue of the "add" prefix has been discussed previously and thus some test scripts do not have that prefix.
I also agree with @afig's analysis on test script names. Renaming any lone README to README also has the advantage of displaying in the README view below the file list on GitHub.
There is an inconsistency on whether test scripts have "add" in their filenames. I would advise that they do not, since the tests are testing the feature's behavior, not necessarily the successful addition of the feature. Additionally, the naming of
runAllPrivilegeTests.psql
is not consistent with other scripts, something liketestPrivileges.psql
may be more appropriate. Likewise, the associated README should be renamed. If the privilege test suite is renamed totestPrivileges.psql
then the README should be renamed totestPrivilegesREADME.txt
.There are other issues related to the structure and behavior of test files, including #207, but they do not have to be addressed in M3.
Current directory structure of the
/tests
directory: