DASSL / ClassDB

An open-source system to let students experiment with relational data
https://dassl.github.io/ClassDB/
Other
8 stars 2 forks source link

Some scripts reference incorrect file names (W) #212

Closed smurthys closed 6 years ago

smurthys commented 6 years ago

Some script files, for example addClassDBRolesMgmtCore.sql, contain incorrect file names. The error seems to have crept in when scripts were re-organized into components.

I am not sure how we go about efficiently finding all such errors.

KevinKelly25 commented 6 years ago

Using Atoms search function to look for all .sql and .psql mentions in the project I found errors in the projects. Here they are

docs\Activity-Logging

docs\Managing-Log-Files

docs\Scripts

docs\Setup

tests\testAddConnectionActivityLoggingCleanup.sql

src\db\reco\addConnectionActivityLoggingReco.sql

src\db\core\addClassDBRolesViewsCore.sql

src\db\core\addClassDBRolesMgmtCore.sql

src\db\core\addUserMgmtCore.sql

src\db\opt\addCatalogMgmtOpt.sql

I will fix all these files that I have found but this may not cover all the errors in the documentation if they were not followed by a .sql or .psql for some reason.

EDIT - Added some missing corrections that need to be made. Also did a strike through for corrections made.

smurthys commented 6 years ago

Good find @KevinKelly25. It is interesting the result does not include any file in the src directory tree though there is at least one source file with the issue. Would you look into that please?

KevinKelly25 commented 6 years ago

I actually just didn't add that to the list because it was mentioned in the first post. I did however, find one reoccurring error in the src files that I missed. I will add them to the list above for clarity.

smurthys commented 6 years ago

Thanks @KevinKelly25 for adding src files to the list.

Please change doc files in the Wiki. Also, I recommend delaying the src file changes until there is a quiescent point, because these kinds of changes can easily cause merge conflicts.

(PS: It helps to add an "EDIT" note to an edited comment so later comments don't look out of place.)

KevinKelly25 commented 6 years ago

Updated the docs to correct the issues. Added strike through for the above list for corrections already made.