Guard uses of DROP OWNED: changed in pg9.5 (N)

[smurthys]

The names CURRENT_USER and SESSION_USER in DROP OWNED is permitted only from pg9.5. Thus, this pattern of code needs to be guarded and executed as dynamic SQL in pg9.4 and earlier.

The script testDisallowSchemaDrop.sql has a few instances that need guarding.

[smurthys]

A few tips for making the changes:

• The changes are all in a test script which is relatively long. So, it is important to keep the script simple. The easiest thing is to avoid adding branches.
• At least one of the instances uses a weird character case for the drop owned query on purpose. It is important to preserve that case.
• Consider creating a temp function such as doDropOwnedByCurrentUser(query) where query is a string that contains the actual query to execute, except it will not have user name. For example, DROP OWNED BY or drOp OWned bY. Complete this query by appending the value of CURRENT_USER and then dynamically execute the completed query.
  • Do not bother with pg version inside this function
  • Add a function prologue that asks this function be removed once support for pg9.4 stops