DASSL / ClassDB

An open-source system to let students experiment with relational data
https://dassl.github.io/ClassDB/
Other
8 stars 2 forks source link

Function importLog will likely import connections made to "unrelated databases" (M) #77

Closed smurthys closed 7 years ago

smurthys commented 7 years ago

This issue is not actually witnessed yet, but is quite likely to exist:

Because the log files are at server level, they will have entries with connections to all databases in the server instance. Function importLog does not discriminate among those entries and thus will record unrelated connections to a user.

A solution is to filter the log entries by database. An alternative is to create a ClassDB database and import the log there with a table of connection information against each user and appropriate functions to list connections (by user). The latter approach maintains connection stats for "unrelated users", but that might be OK.

wildtayne commented 7 years ago

Each log line does have a database field, so it should be straightforward to add a filter by dbname.

smurthys commented 7 years ago

I thought it might be easy. Given the low complexity, I have placed this issue in M1.