search

DASSL / ClassDB

An open-source system to let students experiment with relational data
https://dassl.github.io/ClassDB/
Other
8 stars 2 forks source link

createDBManager asks for managerName, but does not use it (WE) #85

Closed afig closed 7 years ago

afig commented 7 years ago

The createDBManager function in prepareClassDB has an unused parameter: managerName.

The simple fix is to remove the parameter, which might be all that is done for M1.

However, the parameter exists to match the parameters of createInstructor and createStudent. Those functions store xyName in the classdb.Instructor and classdb.Student tables. However, there is no classdb.Manager table in which we could store the value of managerName in. We may wish to consider whether we should have a classdb.Manager table, or possibly even remove the classdb.Instructor table. Currently, DBManager is not consistent with the other roles, and almost appears like it is an afterthought.

smurthys commented 7 years ago

This issue is related to #49.

I am OK removing the managerName parameter.