search

DASSL / Gradebook

Open-source product to provide a practical means for instructors to record student attendance and assessment
Other
8 stars 4 forks source link

createRosterImport.sql and openCloseImport.sql are inconsistent #34

Closed bella004 closed 7 years ago

bella004 commented 7 years ago

openCloseImport.sql creates functions on the gradebook schema, while createRosterImport.sql creates functions on the public schema then uses a gradebook. prefix to refer to the tables. I thought all functions were to be created on the gradebook schema.

If the reason for the prefixes is that the tables could not be recognized any other way (which is the problem I was having for a while), I think it's because a transaction wasn't started prior to the execution of the function, hence the schema can't be set to gradebook. We need to start a transaction then set the local schema to gradebook before executing the set of functions then commit once the functions are done, which can be done in the batch files.

However, if there's a different reason, feel free to close this issue as I'm not sure if this is really an issue or not.

smurthys commented 7 years ago

Yes, the files cited have schema-related issues. We concluded in the last day/two that in general, not to use SET LOCAL SCHEMA and to instead qualify all function and table names with schema name, with createTables.sql and dropTables.sql being the exceptions.

bella004 commented 7 years ago

Okay, thank you for the clarification.