Web Server /login and REST name updates

[wildtayne]

This branch addresses two of the web server items for M1: REST call names:

• Most REST call names have been made plural
• /attendance and /login have been not been changed

/login call:

• Takes the standard database connection parameters and one additional parameter called instructoremail
• If an instructor with the matching email exists, it returns the matching row from the instructor table in the form:

  {
  "instructor":
  {
  "id": <id>
  "fname": "<fname>"
  "mname": "<mname>"
  "lname": "<lname>"
  "department": "<dept>"
  }
  }

• If no matching instructor is found, a 401 error is returned with the body: "Login failed - Instructor does not exist"
• Additional detail has been added to the return bodies of the other 500 errors

[wildtayne]

Thanks for the review. I think it's a good idea to open an issue on the node.js errors. I'll have to do some research to figure out what situations cause node.js to return an internal error. Ideally, I would want to translate any node.js errors into 500 errors, but I'm not sure if that facility exists. At the very least, such detailed information should not be sent to the client.

[smurthys]

BTW, I recommend changing the response string 401 - Login failed - Instructor does not exist to just 401 - Login failed This recommendation is to increase system security.

[smurthys]

Trim values extracted in function creareConnectionParams. Also trim Email on L130.

[wildtayne]

Thanks for the feedback. I've pushed a few commits to address these points. Each user-supplied field is now trimmed before use, and the 401 error message has been made less revealing.

[smurthys]

The changes look good.

[afig]

Latest changes look good.