Add scripts to set sample instructor email addresses

DASSL / Gradebook

Open-source product to provide a practical means for instructors to record student attendance and assessment

Other

8 stars 4 forks source link

Add scripts to set sample instructor email addresses #56

Closed smurthys closed 7 years ago

smurthys commented 7 years ago

The commits in this PR add scripts to add sample e-mail address to instructors.

Here is a summary of the changes:

Added directory /tests/data/InstructorEmail
Added scripts addEmailByInstructorID.sql and addEmailByInstructorName.sql to set e-mail address by ID and name respectively
Updated README in /tests/data to describe the new scripts

Edit: The scripts use the domain example.edu for e-mail addresses so it is easy to distinguish which rows were touched. Using this domain also prevents third parties from (accidentally) sending mails to real addresses if a real domain were used.

smurthys commented 7 years ago

My apologies for the reverted commits. My keyboard and mouse were stuck and got click-happy at some point. So, I had to restart my computer and undo some changes.

smurthys commented 7 years ago

Thanks for the review and I agree TRUNCATE can cause no rows to be affected. FWIW, I thought about that possibility early on and still wrote a simple script because my intention was only to provide a starter script. In retrospect, I should have thought about this differently.

I have revised the scripts to assign e-mail addresses to as many rows as possible. A few things worth noting:

Assigning by name favors using just last name and first initial, and tacks on middle name or ID only if necessary
The logic required and the SQL facility available make it very hard to directly write update queries given the need to assign unique address. Using a temporary table hugely simplifies conflict detection.

smurthys commented 7 years ago

I hope commit 56bb872 does it. The little errors and inconsistencies in edits are often a sign I am doing too many things at once. :(

smurthys commented 7 years ago

OK, maybe commit fce1e80 does it.

The zero-defect approach is hard; but I cannot help but follow it: the struggle of one person is worth the improvement in the quality of many lives.

smurthys commented 7 years ago

After commit b22bb94, I should seriously take a break.

smurthys commented 7 years ago

Sorry about the number of commits. Please review the files anew because they have changed quite a bit.