search

DATA-DOG / go-sqlmock

Sql mock driver for golang to test database interactions
Other
6.13k stars 407 forks source link

Add Column Metadata #231

Closed alespour closed 4 years ago

alespour commented 4 years ago

This is a follow-up to PR #187 that seems to be stalled as the original poster seems to be no longer active). I took the changes and refactored them.

codecov-commenter commented 4 years ago

Codecov Report

Merging #231 into master will increase coverage by 0.38%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   94.20%   94.59%   +0.38%     
==========================================
  Files          18       19       +1     
  Lines         915      980      +65     
==========================================
+ Hits          862      927      +65     
  Misses         38       38              
  Partials       15       15
Impacted Files Coverage Δ
rows.go 89.13% <ø> (ø)
sqlmock.go 93.30% <ø> (ø)
sqlmock_before_go18.go 100.00% <ø> (ø)
column.go 100.00% <100.00%> (ø)
expectations_go18.go 95.45% <100.00%> (+0.71%) :arrow_up:
rows_go18.go 92.85% <100.00%> (+21.42%) :arrow_up:
sqlmock_go18.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b99664...3b533ba. Read the comment docs.

l3pp4rd commented 4 years ago

Thanks, will have a look the coming week

l3pp4rd commented 4 years ago

will check for a while if people find any bugs in master before tagging a release, thanks

alespour commented 4 years ago

will check for a while if people find any bugs in master before tagging a release, thanks

@l3pp4rd what do you think, is it ok now for a new release? Thank you. btw I'm glad you seem to have found new maintainers.