search

DATA-DOG / go-sqlmock

Sql mock driver for golang to test database interactions
Other
6.02k stars 406 forks source link

Adding code to run on Powersystem #243

Closed genisysram closed 2 months ago

genisysram commented 3 years ago

Hi Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

codecov-io commented 3 years ago

Codecov Report

Merging #243 into master will decrease coverage by 0.61%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   94.59%   93.98%   -0.62%     
==========================================
  Files          19       19              
  Lines         980      814     -166     
==========================================
- Hits          927      765     -162     
+ Misses         38       34       -4     
  Partials       15       15
Impacted Files Coverage Δ
rows_go18.go 88.88% <0.00%> (-3.97%) :arrow_down:
expectations.go 84.25% <0.00%> (-2.89%) :arrow_down:
expectations_before_go18.go 85.18% <0.00%> (-1.92%) :arrow_down:
sqlmock.go 92.39% <0.00%> (-0.92%) :arrow_down:
expectations_go18.go 94.87% <0.00%> (-0.59%) :arrow_down:
rows.go 88.73% <0.00%> (-0.40%) :arrow_down:
query.go 100.00% <0.00%> (ø)
column.go 100.00% <0.00%> (ø)
driver.go 100.00% <0.00%> (ø)
result.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f920cc8...748dc15. Read the comment docs.

l3pp4rd commented 3 years ago

Hi, this package is not using unsafe, just mimics the standard sql driver. I do not see the point in testing different archs, which are supported by go.

genisysram commented 3 years ago

@ashhadsheikh Hi please accept my PR

gagantrivedi commented 3 years ago

Hey @genisysram, as @l3pp4rd have already pointed out that this package is not using unsafe so there is no point in testing it on different architecture. Unless you have a different reason in mind we will probably have to close this PR.