search

DATA-DOG / go-sqlmock

Sql mock driver for golang to test database interactions
Other
6.16k stars 407 forks source link

Remove uppercase from the go.mod #286

Closed psankar closed 2 years ago

psankar commented 2 years ago

Right now, the go.mod defines the module name as:

module github.com/DATA-DOG/go-sqlmock

There are problems when we use uppercase names as part of the urls. For example: Artifactory has issues with package name and version in upper case and does not download the packages https://www.jfrog.com/jira/si/jira.issueviews:issue-html/RTFACT-18624/RTFACT-18624.html . It would be a good idea to rename the DATA-DOG to data-dog in the go.mod. If we keep the name in lower case, it would work even if the github project name is in uppercase iiuc.

dolmen commented 2 years ago

Changing to lowercase would be a new import path. This is the same as forking the project.

I have already seen the case change for logrus a few years ago, and it was a mess.

If Artifactory has issues with this project, that's Artifactory that has to be fixed.