search

DATA-DOG / go-txdb

Immutable transaction isolated sql driver for golang
Other
667 stars 48 forks source link

[nit] Set psql/mysql passwords to match Makefile, so `make test` works #52

Closed stefafafan closed 1 year ago

stefafafan commented 1 year ago

related: https://github.com/DATA-DOG/go-txdb/pull/51

To run tests on a local machine with Docker, the command below was originally working

$ docker compose up
$ make test

https://github.com/DATA-DOG/go-txdb/pull/51 set a password explicitly for mysql/psql in the Makefile, which made make test fail.

I went ahead and adjusted the docker-compose.yml so the password matches the Makefile. Now the tests pass locally.

$ make test
...
INSERT 0 3
Opening db...
Opening db...
PASS
ok      github.com/DATA-DOG/go-txdb 0.626s
stefafafan commented 1 year ago

Thanks!