flashing lanterns - possible inconsistency (Bugzilla Bug 352)

[datexii]

This issue was created automatically with bugzilla2github.py

Bugzilla Bug 352

Date: 2021-05-18T10:19:05+02:00 From: @iancornwellmottmac To: @ingeniumfaber

Last updated: 2021-05-18T11:22:10+02:00

[datexii]

Comment 1567

Date: 2021-05-18 10:19:05 +0200 From: @iancornwellmottmac

Just too late for v3.1/CEN 16157-4, Loic Blaive suggested: "I have discovered an inconsistency about flashing lights; it has been updated in the “VmsMessage” package and the old attribute name “lanternsPresent” is still in the “Vms” class. I suggest a better alignment by replacing it by “isFlashingLightsPresent”."

This could not be changed until v4, but there may be scope to update the definition for "lanternsPresent" to align with names in the VmsMessage package. The definition is currently:

"Indicates whether the VMS is equipped with flashing lanterns outside the text or pictogram display areas"

[datexii]

Comment 1568

Date: 2021-05-18 10:22:50 +0200 From: @iancornwellmottmac

I think Loic meant the VmsStatus package, rather than VmsMessage package, because it is the class VmsStatus which has the attribute "flashingLightsOn", whose definition is "Indicates if lights outside display areas (called lanterns in some countries) are turned on."

The arguable minor improvement to tie these together in a backwards compatible way would be to use the same phrasing in the lanternsPresent definition i.e. change "flashing lanterns" to "flashing lights (called lanterns in some countries)".

[datexii]

Comment 1569

Date: 2021-05-18 11:22:10 +0200 From: @iancornwellmottmac

The backwards-compatible definition change was made in revision 1187. The issue will be held open for consideration for v4.