DATx02-16-14 / Hastings

A project evaluating Haste.App and the suitability of Haskell for the web.
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Feature/password protected games #70

Closed Kalior closed 8 years ago

Kalior commented 8 years ago

Makes the games password protected if desired. All games start out as not protected and when a password has been set they can't be unset (has to have some password, can be fixed but I didn't think it relevant in this implementation).

All passwords are sent to the server in clear text where they are hashed using Crypto.PasswordStore. This is because the library didn't work in Haste (got Uncaught TypeError: Cannot read property 'a' of undefined). It means that the communication has to rely on https to ensure that passwords can't be picked up by a malicious person.

The passwords are also in putted in clear text (no **\ fields), can be fixed but didn't think it necessarily relevant to this implementation.

Fixes #68, fixes #9 (last part)

Kalior commented 8 years ago

Have now sufficiently fixed all comments.

Tejpbit commented 8 years ago

Bug:

Apa creates a game, Bepa joins that game and then kicks self. Apa gets duplicate gameControlOwnerDom or whatever you call it :)

Kalior commented 8 years ago

Bug fixed.

Tejpbit commented 8 years ago

Looks good to me. Resolve the conflicts and I'll merge to development