search

DATx02-16-14 / Hastings

A project evaluating Haste.App and the suitability of Haskell for the web.
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Non owner of a game is allowed to kick players. #77

Closed Tejpbit closed 8 years ago

Tejpbit commented 8 years ago

The kick feature shouldn't be available to anyone but the creator of a game.

Kalior commented 8 years ago

You sure about this? And I assume you are referring to the owner of a game, as those will be different.

Tejpbit commented 8 years ago

Yep, i meant owner. Creator is owner at first I guess. But ownership is transferred if creator leaves, yes?

Observation were made on development branch just now. Connect two clients. Create a game with the first. Join that game with the second and kick the first. The firsts clients DOM is set to that of the lobby.

However the list in the game stays the same. Either the DOM isn't updating Or the first client isn't kicked but the wrong DOM is displayed.

Kalior commented 8 years ago

Yes, I acknowledged this problem with the list of players not updated when working on #70 and fixed it right there and then, I believe.

And yes, ownership is transferred to the player that has been in the game the longest.

Tejpbit commented 8 years ago

Did checkout #70 branch. That seems less buggy. If a player is kicked it's actually removed from the player list in the game. But anyone can still kick the owner, which is the creator in this case. Did same procedure as in my last comment to replicate.

Kalior commented 8 years ago

Yes, everyone can kick anyone. It's an easy fix if we don't want it so. Will fix.