search

DATx02-16-14 / Hastings

A project evaluating Haste.App and the suitability of Haskell for the web.
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Feature/store active games in database #91

Closed mattiasnilsen closed 8 years ago

mattiasnilsen commented 8 years ago

I have moved all information stored about a game into the database.

All functionality should work as expected however the tests does not always pass, they fail with an error like: *** Failed! Exception: 'ConnectionError {errFunction = "query", errNumber = 1205, errMessage = "Lock wait timeout exceeded; try restarting transaction"}'

Because of this I have not created any new tests, more investigation is needed into correctly test code where the database is involved.

fixes #86

Kalior commented 8 years ago

I would say tests need to be written, since you changed how some of the core functionality of the lobby works.

Kalior commented 8 years ago

I added some comments to the code, add some tests, but otherwise it looks fine.

Kalior commented 8 years ago

Looks good, a bit bothered by the fact that most tests have to run multiple methods from the database module, but I suppose that is hard to get away from when dealing with a database.

Kalior commented 8 years ago

Why are the games created with some weird string as name?

mattiasnilsen commented 8 years ago

What should the default names for a game be then?

Kalior commented 8 years ago

Something that isn't mega strange, like GameName or default or something

Kalior commented 8 years ago

Perfect, will merge now :partly_sunny: