search

DAVFoundation / dav-js

Enable integration of JavaScript, TypeScript, and Node.js code with the DAV Network
https://developers.dav.network/
MIT License
75 stars 50 forks source link

Add /src/tests folder #131

Closed debragail closed 5 years ago

debragail commented 5 years ago

Moved tests.ts files to tests folder to tidy up directory structure. Edited the path in order for tests to work. All tests confirmed and past in this PR.

Updated package.json and config.jest still in pull request.

mariolo1985 commented 5 years ago

Hey @debragail you must have worn out that . key on your keyboard 😆

Could you look into 2 things before I merge it? There is a conflict between this and master on the package.json file for webpack-cli versions. It may just need a pull from master. Also, I am receive a Gulp error when running the test command npm run jest. It seems there is a migration path on how tasks are defined from gulp@3.9.1 to gulp@4.x.x (https://fettblog.eu/gulp-4-parallel-and-series/). Could you look into resolve that if you are planning to upgrade Gulp? Thanks!

mariolo1985 commented 5 years ago

It looks like you are going to use package.json from master so I added it into this branch along with some chores to get Travis to pass. These are great structure changes. I have merged it to master.

TalAter commented 5 years ago

@debragail , @mariolo1985 Next time, let's have an open discussion in an open issue when you have an idea for a major change before implementing or merging it.

We have a team of 7 developers in house (not to mention the open source team) working on these code bases, and all of the projects have a certain code style and project structure. Changing the structure of one project is something we prefer to discuss first with me and @srfrnk as it affects everyone working on all the projects.

mariolo1985 commented 5 years ago

Yes, that makes sense :+1: will do in the future.

debragail commented 5 years ago

I agree @TalAter I will definitely have a discussion. Was just trying to get PRs going through too hastily and completely agree they need to be discussed first.