DAVFoundation / dav-js

Enable integration of JavaScript, TypeScript, and Node.js code with the DAV Network

https://developers.dav.network/

MIT License

76 stars 51 forks source link

Added the necessary changes to NeedParams.ts, added test file #132

Closed gfting closed 5 years ago

gfting commented 5 years ago

Description

Changed the error getting lat and long values in NeedParams.ts; added testing file.

Related Issue

110 Fixed the issue located here.

Motivation and Context

Fixed the error with lat and long values; added testing to ensure that the constructors were correct after.

How Has This Been Tested?

Created the NeedParams.test.ts file, ran npm run jest to ensure code was correct.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enchancement that improves upon existing functionality

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

gfting commented 5 years ago

While no longer my first commit [I finished a separate issue before I got a response on the this issue thread], this was chronologically the first fix I ever implemented. Thanks!