Closed haialaluf closed 5 years ago
Hi! I would like to handle this issue
Hello @VictoriaKuznetsova it's all yours :smile:
I have question about type of currentVehicleLocation in BidParams. I can't find a class with that name. Maybe it shoud be interface ILocation?
@VictoriaKuznetsova You spotted a bug 👍
I just fixed it and pushed the code. It now imports ILocation
.
About this note: location is internally represented as { lat , lon } but serialized as { latitude , longitude } It doesn't work this way. Function serialize returns { lat , lon } as-is.
Is it by design?
@srfrnk Can you look at @VictoriaKuznetsova 's comment?
About this note: location is internally represented as { lat , lon } but serialized as { latitude , longitude } It doesn't work this way. Function serialize returns { lat , lon } as-is.
Is it by design?
This was irrelevant - removed it. Nice catch.
Great PR @VictoriaKuznetsova! Merged.
Thank you
first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This SDK enabled integrating any client side JS and NodeJS code with the DAV Network.
How you can help
The Issue
Create tests for
ride-hailing/BidParams
using jest.You need to create tests to check that the
serialize
anddeserialize
methods work as expected.Please use the test file for class
NeedParams
as a basis for your new code.Function
serialize
in classBidParams
must return a JSON object that contains all properties defined in theBidParams
instance.Function
deserialize
in classBidParams
receives a JSON string and must initialize all the properties of theBidParams
instance with the values in the JSON string.bidParams1.desrialize(bidParams2.serialize()) == bidParams2
must therefore always be true.NOTE: Some names are changed between protocol string representation of instance properties:
_
but serialized without the prefix. i.e._protocol
becomesprotocol
Contributing to dav-js
up-for-grabs
and not labeledclaimed
, to verify no one else is working on it.$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
$ git push -u origin master
#7
)Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄