Closed haialaluf closed 5 years ago
I'd like to take a shot.
Go ahead @ericcgu 👍
@ericcgu are you still interested in doing this issue?
Hi, I would like to do it.
Hi, I would like to do it.
Is this issue, still persist?
Hi @srdmathur sorry for the late response. This issue still persist. You can start working on it if you still want it :+1:
Thanks for your response. I will start working on this now onwards.
Hi I have coded the changes but the build is failing on Travis for the following commands :
on my local, these commands are working. Can you please check on this?
Hi @srdmathur, the create-dist
command outputs new files that the build is looking for and it is failing there. Good work with the tests! I have merged your changes.
first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This SDK enabled integrating any client side JS and NodeJS code with the DAV Network.
How you can help
The Issue
Create tests for
ride-hailing/NeedParams
using jest.You need to create tests to check that the
serialize
anddeserialize
methods work as expected.Please use the test file for class
NeedParams
as a basis for your new code.Function
serialize
in classNeedParams
must return a JSON object that contains all properties defined in theNeedParams
instance.Function
deserialize
in classNeedParams
receives a JSON string and must initialize all the properties of theNeedParams
instance with the values in the JSON string.needParams1.desrialize(needParams2.serialize()) == needParams2
must therefore always be true.NOTE: Some names are changed between protocol string representation of instance properties:
location
is internally represented as{ lat , lon }
but serialized as{ latitude , longitude }
_
but serialized without the prefix. i.e._protocol
becomesprotocol
Contributing to dav-js
up-for-grabs
and not labeledclaimed
, to verify no one else is working on it.$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
$ git push -u origin master
#7
)Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄