DAVFoundation / dav-js

Enable integration of JavaScript, TypeScript, and Node.js code with the DAV Network
https://developers.dav.network/
MIT License
76 stars 51 forks source link

Create tests for `vessel-charging/messages/ChargingStartedMessageParams` using jest. #25

Open haialaluf opened 5 years ago

haialaluf commented 5 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

dav-js

This SDK enabled integrating any client side JS and NodeJS code with the DAV Network.

How you can help

The Issue

Create tests for vessel-charging/messages/ChargingStartedMessageParams using jest.

You need to create tests to check that the serialize and deserialize methods work as expected.

Please use the test file for class NeedParams as a basis for your new code.

messageParams1.desrialize(messageParams2.serialize()) == messageParams2 must therefore always be true.

NOTE: Some names are changed between protocol string representation of instance properties:

Contributing to dav-js

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

anujanegi commented 5 years ago

I would like to claim this!

TalAter commented 5 years ago

Thanks @anujanegi 👍

Go ahead.

bicep commented 5 years ago

Hi @anujanegi, are you still working on this? If not I'd like to give it a shot :)

anujanegi commented 5 years ago

@bicep Go ahead!

mariolo1985 commented 5 years ago

Hi @bicep are you still interested in working on this?

sark01 commented 4 years ago

Hi @mariolo1985, I see this issue open for close to a year, can I have a go at it ?

mariolo1985 commented 4 years ago

Hi @sark01 - I do not see any open PRs or tests for this so I think you should be ok to take this. Please reach out to @TalAter when you have a PR up. Thanks!

sark01 commented 4 years ago

Sure @mariolo1985, working on it. Thanks