Closed haialaluf closed 5 years ago
I would like to take this!
Thank you @ali-ebner
Please go ahead 👍
@ali-ebner There was a bug in our code that would have prevented you from completing this issue. The bug has since been resolved. Are you still interested in doing this issue?
@TalAter I meant to get in touch with you about the bug. Unfortunately, I am no longer able to do the issue at this time. Apologies!
@TalAter, Could I take this one up?
@TalAter @mariolo1985: While I was exploring the codebase last night, I found quite a few test classes which don't have deserialize tests to check for both the instance and the object content. So I was wondering whether it would be okay if I create a couple of new issues related to that in this repository?
Hi @sark01 you certainly can take this issue 😃
In regards to classes without deserialize tests, we are reviewing them and will most likely open up issues for those. Keep an eye out in the near future 👓 thanks!
@sark01 For the other issues - since they are very similar to this one - I think it will be a good chance to give more and more people a chance to get their start with open source with them... while you can take up some different issues and learn more about the project 👍
@TalAter I've been meaning to raise this point. I think its better if I don't consume the rest of the issues as I believe I've kinda figured how to fix them and give the newcomers a chance. I believe contributing to open-source can be daunting at first as it was for me a couple of weeks back. I thank you and the maintainers of this repository for helping me gain a thorough insight into how open-source contributions are made. Meanwhile, I could try my hand at some newer issues not related to the ones I've fixed.
Thanks for the PR @sark01. Great work!
Sounds good @sark01
Also, now that you have had some experience with the project feel free to suggest other improvements you think should be made.
Thank you for all the help so far 👍
first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This SDK enabled integrating any client side JS and NodeJS code with the DAV Network.
How you can help
The Issue
Create tests for
vessel-charging/messages/StartingMessageParams
using jest.You need to create tests to check that the
serialize
anddeserialize
methods work as expected.Please use the test file for class
NeedParams
as a basis for your new code.Function
serialize
in classMessageParams
must return a JSON object that contains all properties defined in theMessageParams
instance.Function
deserialize
in classMessageParams
receives a JSON string and must initialize all the properties of theMessageParams
instance with the values in the JSON string.messageParams1.desrialize(messageParams2.serialize()) == messageParams2
must therefore always be true.NOTE: Some names are changed between protocol string representation of instance properties:
location
is internally represented as{ lat , lon }
but serialized as{ latitude , longitude }
_
but serialized without the prefix. i.e._protocol
becomesprotocol
Contributing to dav-js
up-for-grabs
and not labeledclaimed
, to verify no one else is working on it.$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
$ git push -u origin master
#7
)Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄