DAVFoundation / dav-js

Enable integration of JavaScript, TypeScript, and Node.js code with the DAV Network
https://developers.dav.network/
MIT License
75 stars 51 forks source link

Created tests for `vessel-charging/MissionParams` #19 #34

Closed paul-bartlett closed 5 years ago

paul-bartlett commented 5 years ago

Description

Added MissionParams.test.ts in src/vessel-charging

Related Issue

This is for the open issue #19 titled "Create tests for vessel-charging/MissionParams using jest."

Motivation and Context

The tests verify that the serialize and deserialize work as intended

How Has This Been Tested?

Set up the project on my machine and ran jest successfully

Types of changes

Checklist:

TalAter commented 5 years ago

Thank you @paul-bartlett

I've asked @srfrnk to check it out.

TalAter commented 5 years ago

Thank you @paul-bartlett 👍

I've simplified the serializing test a bit... just a personal preference. I think it's good to have a simple basic test that tests the simplest possible object, and then add additional atomic tests to test the additional features.

Other than that, it looks great!