Remove unneeded code (first-timers-only)

TalAter commented 5 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

dav-js

This repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.

How you can help

In order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests, are simple readable tests.

There's a good opportunity to simplify one of our tests:

In src/Bid.test.ts when bidParams is defined we give it a value (a new BidParams object). But that value is immediately overwritten in the beforeEach function. Change the code so that bidParams is just defined, and isn't immediately assigned a value. While we're at it, and since this is TypeScript, give it a type of BidParams.

bidparams

After making your changes, make sure the tests still pass by running npm run jest

Contributing to dav-js

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Open dav-js GitHub page and click the ★ Star and then ⑂ Fork buttons.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
[ ] Code Code Code
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/dav-js) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #7)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

devkant commented 5 years ago

Can I try this?

TalAter commented 5 years ago

Please, go ahead @devkant

srfrnk commented 5 years ago

Can we hold this task for now? It is a bad practice to use global scope in tests. The code you are about to remove is what should remain. The global code should be deleted.

devkant commented 5 years ago

Ok I will stop working on it.

TalAter commented 5 years ago

Closing for now. Will discuss with @srfrnk

TalAter commented 5 years ago

@devkant - You've asked to do both this and #41 I would prefer if you take just one issue at a time and give someone else a chance to try this one.

I closed this, and reopened it as a new issue.

DAVFoundation / dav-js