#62 tsconfig - remove unnecessary commas from file - Githubissues

DAVFoundation / dav-js

Enable integration of JavaScript, TypeScript, and Node.js code with the DAV Network

https://developers.dav.network/

MIT License

76 stars 51 forks source link

#62 tsconfig - remove unnecessary commas from file #65

Closed abuna1985 closed 5 years ago

abuna1985 commented 5 years ago

Description

I removed all trailing commas from the tsconfig.json file which makes it a valid JSON object.

Related Issue

Remove trailing commas in tsconfig.json (first-timers-only) #62

Motivation and Context

JSON does not allow a trailing comma, which means that if you run this file, you will get an error. Removing the commas will fix this.

How Has This Been Tested?

I ran node tsconfig.json with with the additional commas in place and received the following error

screen shot 2018-09-29 at 11 09 08 am

After removing the trailing commas, I ran node tsconfig.json and received no errors

screen shot 2018-09-29 at 11 13 13 am

Screenshots (if appropriate):

Before:

trailingcomma

After:

screen shot 2018-09-29 at 11 22 17 am

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

mariolo1985 commented 5 years ago

hey @abuna1985! 1985 was a good year 😄 Thanks for contributing. I like that you provided a test workflow in the PR (even when there wasn't one implemented). Great work!

Syntactical formatting is always a debatable and opinionated topic so I like to leave it to linters and project rules vs unit testing. It may be something to think about adding to this project.