DAVFoundation / dav-js

Enable integration of JavaScript, TypeScript, and Node.js code with the DAV Network
https://developers.dav.network/
MIT License
76 stars 51 forks source link

Fixed #69 #69

Closed ghost closed 5 years ago

ghost commented 5 years ago

Updated lines 4-6 and 8-13 by defining them to be mutable.

Description

Defined the parameters to be mutable. Less const more let!

Related Issue

Motivation and Context

It allows for more dynamic tests.

How Has This Been Tested?

TalAter pointed out that I was missing a semicolon. after adding the semicolon I used "npm run tslint" to test; it also showed "gulp is not recognized" but no other issues.

Screenshots (if appropriate):

Types of changes

Checklist:

mariolo1985 commented 5 years ago

Hi @Wmccra thanks for taking on this issue for us. Could you update the initial post in this PR with the default description below? Thank you :smile:

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Related Issue
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have read the **CONTRIBUTING** document.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
mariolo1985 commented 5 years ago

Hi @TalAter Travis is not building successfully. Please see https://travis-ci.org/DAVFoundation/dav-js/jobs/435698677#L887

I do not see a fork to clone.