Closed mariolo1985 closed 5 years ago
@mariolo1985 Can I take this?
Yes you can @vincentle! 😄
Hi @vincentle are you still interested in working on this?
I claim it :) @mariolo1985
Hi @abdchehadeh it's all yours! Thanks 😄
Test Suites: 2 failed, 33 passed, 35 total Tests: 23 skipped, 114 passed, 137 total Snapshots: 0 total Time: 16.97s Ran all test suites. [19:22:04] 'jest' errored after 17 s [19:22:04] Error in plugin "gulp-jest"
This is the outcome of
npm run jest
is this the current state of the project ?
Thank you @abdchehadeh 👍
Looks great
first-timers-only
This issue is tagged 🕺 first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.
How you can help
In order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests are simple, readable tests.
Here is a good opportunity to simplify one of our tests.
The Issue
We need to add a test for the
serialze()
method in src/ride-hailing/NeedFilterParams.test.ts. This test is for src/ride-hailing/NeedFilterParams.ts.Please add a test similar to this:
An example can be found here.
After making your changes, run
npm run jest
to make sure our tests are passing.Contributing to dav-js
up-for-grabs
and not labeledclaimed
, to verify no one else is working on it.$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
npm install
npm run jest
npm run jest
again$ git push -u origin master
#7
)Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄