Closed mariolo1985 closed 5 years ago
I'd like to tackle this issue!
Go for it @lucasheim :smiley:
Hey @lucasheim great work! Thanks for the help. I have merged your changes. We have other open issues similar to this when you want to take on another one 👍
first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.
How you can help
In order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests are simple, readable tests.
Here is a good opportunity to simplify one of our tests.
The Issue
We currently do not have unit testing set up for src/drone-charging/NeedFilterParams.ts. Please create Jest tests for the
serialize()
anddeserialize()
methods.A good reference point for the
serialize()
test would be src/ride-hailing/NeedFilterParams.test.ts and src/ride-hailing/MissionParams.test.ts for thedeserialize()
test. Customize it to the expected parameters and properties. If you are unsure what is expected, runnpm run jest
in the terminal and it should give you a hint. Also, you can reach out to our gitter channel with any questions 😄The test you write will be similar to this:
After making your changes, run
npm run tslint
andnpm run jest
to make sure our tests are passing.Contributing to dav-js
up-for-grabs
and not labeledclaimed
, to verify no one else is working on it.$ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
npm install
$ git push -u origin master
#7
)Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄