DAVFoundation / missioncontrol

🛰 Controls and orchestrates missions between vehicles and DAV users
MIT License
181 stars 156 forks source link

randomRating() method should return a float (first-timers-only) #13

Closed TalAter closed 7 years ago

TalAter commented 7 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues here:

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Mission Control

The DAV project you are looking at is Mission Control. It is the brain in charge of orchestrating missions between DAV users and autonomous vehicles.

How you can help

Background

To help developers building on top of DAV technologies, Mission Control can start in a simulation environment. In a simulation environment, there are always a few simulated drones flying around the user, ready to take on missions. This makes it easy for developers to start building and testing without investing in hardware.

The Issue

When creating a new simulated drone, it needs to have a rating based on its past performance (e.g. 4.9). A rating is a float between 1.0 and 5.0. Currently, the method that creates this rating returns the rating as a string.

The function randomRating() inside /server/simulation/random.js needs to be updated to use toFixed(1) instead of toPrecision(2). You can read more about the difference between toFixed and toPrecision.

To test your function, follow the instructions in Contributing to Mission Control, and after you write your code visit http://localhost:8888/status.

Contributing to Mission Control

TalAter commented 7 years ago

Fixed by @Govorin in #21 Thank you.