search

DAVFoundation / missioncontrol

🛰 Controls and orchestrates missions between vehicles and DAV users
MIT License
181 stars 156 forks source link

Vehicle's coordinates are represented by coords rather than long and lat property #178

Closed bicep closed 6 years ago

bicep commented 6 years ago

Description

Refactored code in a way that makes a clearer distinction between the vehicle object returned by redis (with long and lat property) and our internal representation of the vehicle object (with coords property). We represent all numbers properly as int and floats instead of strings. Refactored some of the code in the signup controller and also made sure that our internal representation of our vehicle has a status property.

Related Issue

Issue #173

Motivation and Context

Standardized format for how the redis vehicle object should be formatted.

How Has This Been Tested?

Not rigorously enough probably- just using the missions app to make sure there are no errors. getVehicle for instance is used by a lot of other functions. How can I rigorously test each function to make sure that they are all not broken now that they are using the new vehicle formatting?

srfrnk commented 6 years ago

Thanks @bicep :tada:

TalAter commented 6 years ago

@srfrnk I was just merging it... you beat me to it :)

Thanks @bicep 💪