DAVFoundation / missioncontrol

🛰 Controls and orchestrates missions between vehicles and DAV users
MIT License
181 stars 156 forks source link

Add tests to check randomDavAddress() (first-timers-only) #18

Closed TalAter closed 7 years ago

TalAter commented 7 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues here:

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Mission Control

The DAV project you are looking at is Mission Control. It is the brain in charge of orchestrating missions between DAV users and autonomous vehicles.

How you can help

Background

To help developers building on top of DAV technologies, Mission Control can start in a simulation environment. In a simulation environment, there are always a few simulated drones flying around the user, ready to take on missions. This makes it easy for developers to start building and testing without investing in hardware.

The Issue

As a project that relies on a large community of contributors, it is very important for us to have good tests to make sure changes don't break anything.

One of the functions that need testing is the function that creates random unique ids for the drones.

The function randomDavAddress() inside /server/simulation/random.js needs to be tested to make sure it:

Edit test/specs/simulation.random.spec.js, adding a describe block for randomDavAddress() and within it two tests that verify the two conditions mentioned above.

To run your tests, run npm js from the project's root directory. All tests should pass.

tests

Contributing to Mission Control

TalAter commented 7 years ago

Claimed by @ankmachine

TalAter commented 7 years ago

Merged. Works perfectly. Thank you for the help once more.