Closed cg-cnu closed 7 years ago
I would like to work on it
@riktimmondal Sure pick it up 👍
Thank you @riktimmondal
I wrote a few comments on #32, but other than that this is a great first pull request! Congratulations on becoming an open sourcer! I hope this is the first contribution of many.
first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues here:
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
Mission Control
The DAV project you are looking at is Mission Control. It is the brain in charge of orchestrating missions between DAV users and autonomous vehicles.
How you can help
Background
To help developers building on top of DAV technologies, Mission Control can start in a simulation environment. In a simulation environment, there are always a few simulated drones flying around the user, ready to take on missions. This makes it easy for developers to start building and testing without investing in hardware.
The Issue
As a project that relies on a large community of contributors, it is very important for us to have good tests to make sure changes don't break anything.
One of the functions that need testing is
randomMissionsCompleted()
inside /server/simulation/random.js that creates random number ofmissionsCompleted
andmissionsCompleted7Days
.The task for this issue is to test the functions return value.
4 and 90
Edit
test/specs/simulation.random.spec.js
, adding adescribe
block forrandomMissionsCompleted()
if it does not exists and within it one test that verify the condition mentioned above.To run your tests, run
npm test
from the project's root directory. All tests should pass.Contributing to Mission Control
$ git clone git@github.com:YOUR-GITHUB-USER-NAME/missioncontrol.git
$ cd missioncontrol; npm install
npm test
to run linting checks and all the automated tests and see that they pass.npm test
one last time and make sure no errors (including linting errors) are thrown.$ git push -u origin master
#29
)