Add tests to check randomMissionsCompleted() returns an object

TalAter commented 7 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues here:

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Mission Control

The DAV project you are looking at is Mission Control. It is the brain in charge of orchestrating missions between DAV users and autonomous vehicles.

How you can help

Background

To help developers building on top of DAV technologies, Mission Control can start in a simulation environment. In a simulation environment, there are always a few simulated drones flying around the user, ready to take on missions. This makes it easy for developers to start building and testing without investing in hardware.

The Issue

As a project that relies on a large community of contributors, it is very important for us to have good tests to make sure changes don't break anything.

One of the functions that need testing is randomMissionsCompleted() inside /server/simulation/random.js that creates random number of missionsCompleted and missionsCompleted7Days.

The task for this issue is to test the functions return value to make sure

it returns an object

Edit test/specs/simulation.random.spec.js, adding a describe block for randomMissionsCompleted() and within it one test that verify the condition mentioned above.

To run your tests, run npm test from the project's root directory. All tests should pass.

tests

Contributing to Mission Control

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Fork the repository from the Mission Control GitHub page.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/missioncontrol.git
[ ] Make sure you have node.js and npm installed on your machine. You can use this guide for help.
[ ] Install all of the project's dependencies with npm. $ cd missioncontrol; npm install
[ ] Run npm test to run linting checks and all the automated tests and see that they pass.
[ ] Code! code! code!
[ ] Before committing your code, run npm test one last time and make sure no errors (including linting errors) are thrown.
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missioncontrol) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #27)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

woodske commented 7 years ago

I'd like to give this a shot if it's still available.

TalAter commented 7 years ago

Go for it! Thank you. 🙇

TalAter commented 7 years ago

Please join our contributors gitter channel where you can get help, and help other contributors.

woodske commented 7 years ago

It looks like this has been done already.

describe('randomMissionsCompleted()', () => {

  test('returns an object', () => {
    expect(
      typeof randomMissionsCompleted()
    ).toBe('object');
  });

cg-cnu commented 6 years ago

Hi @woodske, thanks for your interest in contributing. 👍 Yes, the issues seems to be already fixed. Sorry for the confusion. Feel free to pick up some other issue 😄

DAVFoundation / missioncontrol