Add tests to check missions_completed attribute in random drone generator (first-timers-only)

cg-cnu commented 6 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.

Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.

Find more first-timers-only issues here:

Thank you for your help :heart:

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Mission Control

The DAV project you are looking at is Mission Control. It is the brain in charge of orchestrating missions between DAV users and autonomous vehicles.

How you can help

Background

To help developers building on top of DAV technologies, Mission Control can start in a simulation environment. In a simulation environment, there are always a few simulated drones flying around the user, ready to take on missions. This makes it easy for developers to start building and testing without investing in hardware.

The Issue

As a project that relies on a large community of contributors, it is very important for us to have good tests to make sure changes don't break anything.

One of the functions that need testing is generateRandom() inside /server/simulation/drone.js that creates random simulated drones

Your task is to extend the test spec in test/specs/simulation.drone.spec.js to test the following condition:

it returns an object containing a missions_completed attribute.

Edit test/specs/simulation.drone.spec.js, adding a test that verifies the above condition.

To run your tests, run npm test from the project's root directory. All tests should pass.

tests

Contributing to Mission Control

[ ] Fork the repository from the Mission Control GitHub page.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/missioncontrol.git
[ ] Make sure you have node.js and npm installed on your machine. You can use this guide for help.
[ ] Install all of the project's dependencies with npm. $ cd missioncontrol; npm install
[ ] Run npm test to run linting checks and all the automated tests and see that they pass.
[ ] Code! code! code!
[ ] Before committing your code, run npm test one last time and make sure no errors (including linting errors) are thrown.
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missioncontrol) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #65)

3licks commented 6 years ago

Can I take this?

cg-cnu commented 6 years ago

@FelixJ20000 Thanks for your interest in contributing to missioncontrol. We are waiting for other contributor to respond. Have a look around and see if you like to work on some other stuff. Meanwhile you can also join our chat room We will be creating more issues in the coming days. 😄

TalAter commented 6 years ago

@FelixJ20000 It looks like this one is available again. Want to take a shot at it?

joeydlee95 commented 6 years ago

Hi, I still saw that this issue has been up for grabs and was wondering if I can work on this project?

cg-cnu commented 6 years ago

Hey @joeydlee95 Looks like couple of people have showed interest but never came back. You can pick it up. Am labeling this as claimed. Let me know if you have any questions 🙂

DAVFoundation / missioncontrol