Issue Changed RPC Server component's background color

edxds commented 6 years ago

Description

Changed background color/gradient/filter for elements in style.css and changed tint for last block and mining status' icons.

Screenshots (if appropriate):

pr_new_ui

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

edxds commented 6 years ago

I had submitted the PR before formatting, sorry! Edited now.

cg-cnu commented 6 years ago

Hey @edxds Thanks for your work ❤️ But, unfortunately you are trying to close more issues than you have picked up.

We create these first-timer-only issues as a way for people who have never contributed to open-source to try their first pull request.

As you can imagine, it actually takes a lot more time to write these issues than it would have for us to simply solve them ourselves, but we do that as a way to give as many new people a chance to get involved with open source for the first time.

And we think this method works great as a way to make open-source more inviting. It has obviously succeeded in giving you a lot of enthusiasm to contribute, as can be seen by this pull request 😃

Unfortunately, when you close 3 issues at once like this, we are missing out on an opportunity for 2 more people to make their first ever pull request.

We just want to make it absolutely clear that there is nothing wrong with the code you contributed! We will be happy to accept the pull request once you edit it so that you only solve one of those 3 issues. This will give two more people a chance to do their own first pull request, and everybody wins 🏅

Thank you again for the enthusiasm, and for spending the time to help the community. We really do appreciate it, and I hope you understand. 😄

This pr is supposed to fix the background color of only RPC Server component. Would you mind creating one more pr with just fixing that ?

edxds commented 6 years ago

Sure thing! I guess I got carried away following the mockup included in the issue. I will open up another PR.

DAVFoundation / xplore