#95 Changed RPC component's background color

DAVFoundation / xplore

⛓ A block explorer for local Ethereum testnets

MIT License

62 stars 65 forks source link

#95 Changed RPC component's background color #102

Closed edxds closed 6 years ago

edxds commented 6 years ago

Description

Changed the RPC component's background color/gradient as described in issue #95

Screenshots (if appropriate):

pr_fixed

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

cg-cnu commented 6 years ago

Hey @edxds can you compare the background gradient with the one shown in the mockup and fix it ? Right now its just a single plain color. 🙂

edxds commented 6 years ago

Done!

cg-cnu commented 6 years ago

Hey @edxds I think there is a serious miscommunication going on here...

Let me explain clearly, you are working on this issue https://github.com/DAVFoundation/xplore/issues/95 which deals with fixing the background color of the RPC Component.

Which means you are supposed to change the background color of the RPC Component from this... to this... by changing the css values.

Would you mind fixing it and creating one more pr ? Thanks! Let me know if you have any questions. You are almost there, lets wrap this one up! 😄

cg-cnu commented 6 years ago

Hey @edxds We have changed the design of xplore app and this PR is no longer valid. Am sorry, but we have to close this PR. I will be creating more first-timer issues soon. Please feel free to pickup any of them. Thanks 🙂