Remove unnecessary return statement from transactions [first-timers-only]

griffobeid commented 6 years ago

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before and are looking for an easy way take their first steps.

Consider this as your chance to dip your toe into the world of open-source and get some bragging rights for writing code that makes drones fly, cars find charging stations, helps people and goods move from place to place and more...

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help ❤️

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new non-profit foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Xplore

The DAV project you are looking at is Xplore. Xplore is a blockchain explorer you can run on your machine to explore local Ethereum nodes on your machine. It is used by developers working with DAV's libraries to ease development and see how the blockchain is affected by their work.

How you can help

The Issue

In the file src/reducers/transactions.js the arrow function can be simplified to return the value without the return statement.

For example:
[getAccountsFulfilled]: (state, { payload }) => { return payload; }

Can be simplified to: [getAccountsFulfilled]: (state, { payload }) => payload;

Contributing to Xplore

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Open the Xplore GitHub page and click the ★ Star and then ⑂ Fork buttons.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/xplore.git
[ ] Visit the contributing guidelines for help getting started.
[ ] Code, code, code...
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/xplore) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #5)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

amit3992 commented 6 years ago

I would love to help here

griffobeid commented 6 years ago

Go for it, @amit3992 👍

TalAter commented 6 years ago

Thank you @amit3992 and congrats on making your first :octocat: pull request!

I hope this is the first of many contributions to open source.

Please join us on our gitter channel where we discuss more opportunities to get involved with DAV and Open Source in general

DAVFoundation / xplore