Updated CONTRIBUTING.md with installation steps for Windows

mariuslazar93 commented 6 years ago

Description

Updated CONTRIBUTING.md file with a step by step guide for Windows users that encounter issues during installation.

Motivation and Context

When a user is trying to install this app on Windows, it is possible to encounter a few issues due to the node-gyp package.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

TalAter commented 6 years ago

@cg-cnu It looks good, but I can't verify as I am not on Windows.

Can you either verify it (if you still have your Windows machine), or ask someone who complained about the issue in Windows to take a look?

Once you're happy with it, feel free to merge.

cg-cnu commented 6 years ago

Thanks for your help @mariuslazar93 👏 Really appreciate putting in the time to write the instructions. Feel free to join our gitter channel to find out more opportunities to contribute 🙂

DAVFoundation / xplore