search

DBCDK / biblo-admin

Admin application for biblo
0 stars 3 forks source link

Feature/profiles list filters #76

Closed kallehauge closed 8 years ago

kallehauge commented 8 years ago

This PR does three things:

  1. Generalise the "open" state of ProfilesFilterForm.
  2. Add additional optional filter conditions.
  3. Make the quarantine filter option work with additional where conditions.
kallehauge commented 8 years ago

Scrutinizer failed on two "this might be duplicated code" - I've ignored them both so see the build as successful :smile:

kasperg commented 8 years ago

@kallehauge Looks good.

I have introduced 2e1d602 to reduce the filtering complexity (and fix the duplicated code).