DBChoco / Muezzin

A prayer times (Adhan) and Quran app for Windows, macOS and GNU/Linux.
MIT License
134 stars 17 forks source link

The black area of time changed in size over time #11

Closed AbdelmalekBouguerra closed 1 year ago

AbdelmalekBouguerra commented 2 years ago

Alsalam w ealaykum w rahmat allah w barakatuh ramadan mubarak.

I did notice this when using the application it not a big deal but if it is fixed it will give more elegance to your application. I love your work very useful for my use case. thank you for you eforts , god bless you.

Nouveau projet

DBChoco commented 2 years ago

Wa Alaykoum Assalamou wa Rahmatou Lahi wa Baraketu brother! Ramadan Moubarak to you too !

Do you think that a fixed area would be better than a dynamic one ? Would you prefer it like this ?

Jazzaka Lahu khairan for the sweet comment, I appreciate it. I'm glad it's useful to someone other than me hahaha. Bless you too.

AbdelmalekBouguerra commented 2 years ago

yes brother it will be much better. of course you have created a modern and easy to use app, nothing like it in the market as far as i know. wafaqak allah.

AbdelmalekBouguerra commented 2 years ago

same thing here if you maybe write the time in a new line, it won't change the size of the area over time. image

DBChoco commented 2 years ago

You may be right brother, even though I don't like it very much to be honest. However if I'm going to do it it's probably going to be quite the hassle because I'd need to take into consideration multiple things:

You are right that the fact that it moves each second may be disturbing, but to fix that, you can disable the seconds in the settings, it'll become much more static. Perhaps that might be to your liking. What do you think brother ?

AbdelmalekBouguerra commented 2 years ago

true it helps a lot, i didnt search in the options my bad. very well made thank you a lot. Jazzaka Lahu khairan

DBChoco commented 2 years ago

No problem brother, if you have any other issues or questions you can always ask. Wa iyak Jazzaka Lahu khairan!

meypod commented 1 year ago

@DBChoco you can use a monospace variant of the font you use (if it has, or another font if it does not have) for the numbers part simply wrap the numbers in a <span> or <div> and apply the monospace font only to it this will help the issue and wont require changing the overall look significantly

DBChoco commented 1 year ago

image Very nice suggestion brother, I didn't know it existed. Jazzaka Lahu khairan; how do you like it ?

meypod commented 1 year ago

It would be nice if you could find a similar font with monospace variant of it for a more unified look or change the main fonts to something that also has a monospace variant

but it looks ok now as well, the most important part for myself was to prevent text from moving from it's place when it changes

nice work

DBChoco commented 1 year ago

The thing is that I really like the Quicksilver font (the main one) so I don't want to change it. InshaAllah I'll try to find some other monospace font that is similar or at least compatible.

DBChoco commented 1 year ago

Thanks to Allah and this website I managed to convert the font I used to monospace https://graphicdesign.stackexchange.com/questions/10644/how-can-i-make-a-font-monospaced, now it should be pretty uniform: image The "1" is a bit small and it's quite awkward to have it take so much space, but it's better than to have it move all over.

meypod commented 1 year ago

nice looks good

DBChoco commented 1 year ago

It's good that you like it, I'll inshaAllah close the issue once I push all the changes.

meypod commented 1 year ago

It may be a good idea to also apply it to the prayer times in the table, they will look more aligned/tidy but it doesn't matter much as they don't move

DBChoco commented 1 year ago

Truly nice idea, I didn't think about it even for a second ! This is how it looks and Alhamdoulillah I think it looks awesome: image

DBChoco commented 1 year ago

Fixed with this https://github.com/DBChoco/Muezzin/commit/4ba09484388d298ff636eeb020d7802edb0f64ad Jazzaka Lahu khairan