search

DBuildService / dbs-server

BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

deal with the unknown image id in client imageinfo call #17

Closed vpavlin closed 9 years ago

vpavlin commented 9 years ago

$ python dbs-client.py --server dbs-stg2.usersys.redhat.com imageinfo 88 Getting data: {u'url': u'http://dbs-stg2.usersys.redhat.com/v1/image/88/info', u'data': None} Traceback (most recent call last): File "dbs-client.py", line 3, in main() File "/home/vpavlin/devel/tmp/dbs/dbs-client/dbs_client/client.py", line 229, in main return args.func(args) File "/home/vpavlin/devel/tmp/dbs/dbs-client/dbs_client/client.py", line 109, in action_imageinfo output = subcommands.action_imageinfo(args=payload) File "/home/vpavlin/devel/tmp/dbs/dbs-client/dbs_client/subcommands.py", line 205, in action_imageinfo return _default_get('{{0}}/image/{0}/info'.format(image), data, args, user) File "/home/vpavlin/devel/tmp/dbs/dbs-client/dbs_client/subcommands.py", line 155, in _default_get output = _get_data(req) File "/home/vpavlin/devel/tmp/dbs/dbs-client/dbs_client/subcommands.py", line 81, in _get_data "Unknown response from the server. The response was: {0}".format(req.text)) dbs_client.exceptions.DBSCliUnknownResponseException: Unknown response from the server. The response was: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

500 Internal Server Error

Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator at root@localhost to inform them of the time this error occurred, and the actions you performed just before this error.

More information about this error may be available in the server error log.

TomasTomecek commented 9 years ago

This should be fixed with get_object_or_404. But I wonder why this thing didn't kick in: https://github.com/DBuildService/dbs-server/blob/master/dbs/api/views.py#L54.