Request: brightness slider

DBuit / Homekit-panel-card

Homekit panel card for home assistant

MIT License

304 stars 54 forks source link

Request: brightness slider #38

Closed capstan1 closed 4 years ago

capstan1 commented 4 years ago

I've got a new feature request: brightness slider on the card. The popup card is nice, but having the slider right inside the tile would be HUGE. This would be especially helpful with wider cards. I made this mockup:

If wanted, this could also show the color (not so nice with my current theme, but you get the idea):

What do you think?

DBuit commented 4 years ago

Hi man,

Looks cool i'm gonna try to make an working example. i think i can be hard to use the slider with the text on top of it need to try this.

DBuit commented 4 years ago

Made a working example in html/css: https://codepen.io/dbuit/pen/MWwLOBx So it could work

capstan1 commented 4 years ago

Wow that was fast and it looks gorgeous! Only downside I could think off: How would one toggle the lights? You could "block" the tapping on the bar for brightness adjustments (just swiping adjusts brightness, tapping toggles. Hue uses an additional switch for a similar concept: https://youtu.be/VOBo_UAplQQ?t=89 Not sure if that is what you are going for.

But thanks again for even considering my concepts and being so quick! Definitely will drop yome coffees when the paycheck arrives!

DBuit commented 4 years ago

@capstan1

Hi i just released beta version with this implemented in the card if you wanna test it out :)

capstan1 commented 4 years ago

Wow thats great! Just How what I was thinking! It is so convenient like this! Also great how you found a solution for the "tapping issue".

I uncovered some bugs, though:

wider cards don't use the whole width for the slider. The last part is never used. For normal sized cards it is used, though:
If the light is turned of, the slider knob moves to the middle. Looks weird if you turn it off with sliding it to the far left and it just jumps to the middle (However, if I turn a light off first by tapping and then move the slider all the way to the left it stays there.)

Do you think global variables for some of the values can be implemented in the future? For example, I'd like to use the slider, wider and halfheight for all cards.

Thanks again! You're great!

DBuit commented 4 years ago

Hi,

just released new version, this fixes the width and height of the slider when using wider of higher option.