search

DBuit / Homekit-panel-card

Homekit panel card for home assistant
MIT License
304 stars 54 forks source link

Error on Popup after Upgrade to 0.113 #69

Closed briis closed 4 years ago

briis commented 4 years ago

After upgrading to 0.113, I start getting the following error, when clicking a button that calls a Popup:

https://MYIPADDRESS/hacsfiles/Homekit-panel-card/homekit-panel-card.js:1407:14 Uncaught TypeError: Cannot read property 'close' of undefined

The popup never occurs, so I can no longer control my Media players and Switches that have popups.

DBuit commented 4 years ago

Hi @briis ,

The popups are possible with the use of card tools by thomasloven. He is working on an update to fix this. When this update it out i will update the card to fix this

briis commented 4 years ago

Perfect, thanks. And congratulations with your new baby.

mmonkey commented 4 years ago

@DBuit confirmed working again after latest update, but now on every popup <div class="main-title">test</div> is rendered.

mmonkey commented 4 years ago

@DBuit Also, settings on popups no longer display (i.e. light-popup-card settings: true)

caseyjhol commented 4 years ago

Also, it seems the popup is too big (when viewing in the browser on desktop), as it fills almost the entire window, so clicking outside of the popup to close it is made more difficult.

DBuit commented 4 years ago

I Will check the test title and the settings tomorrow. @caseyjhol thuis is stille i bug in card tools it has a closePopup function buy thuis is not working at the moment

briis commented 4 years ago

It works for me now, thanks for fixing @DBuit. I will close this issue.