search

DBuit / light-popup-card

Lovelace card to use as custom pop-up for light in homekit style
167 stars 38 forks source link

overflow:hidden css attribute make a long scene name truncated #4

Closed septeven closed 4 years ago

septeven commented 4 years ago

Hi, Great work here - just noticed that my "long" scene name ("concentration") was truncated because of the overflow:hidden attribute of scene name.

For now, I edited the js file in order to fix it but would you mind adding a permanent fix for this ?

Also, would be great if we can close the popup by clicking/taping in the empty space, instead of clicking on the cross icon.

Thanks

DBuit commented 4 years ago

Hey man,

Can you post what you edited in the js file that makes it faster to fix :) I had feature to close the popup by clicking in the empty space on my list will add that

septeven commented 4 years ago

I actually just deleted the overflow:hidden attribute, line 302 (under .scene-holder .scene .name), but I'm not an expert in css, just have some basics, thus I'm not sure that it would be the best way to fix it.

Glad to know you'll add the closing feature.

Also, one last thing here, would it be possible to add a feature in order to call a script instead of a scene (I made scripts for lights that I would love to call from your popup)

DBuit commented 4 years ago

Are the scene names not going over each other now? can you show screenshot wonder how yours looks :)

DBuit commented 4 years ago

You can also close the pop-up now by clicking in open space in the new update. I renamed the project and update structure to meet hacs requirements!

septeven commented 4 years ago

Are the scene names not going over each other now? can you show screenshot wonder how yours looks :)

See "concentratio" instead of "concentration"

Capture d’écran 2020-01-07 à 19 01 32

You can also close the pop-up now by clicking in open space in the new update. I renamed the project and update structure to meet hacs requirements!

This is great, thanks for that.

I can see that you are going to implement the use of scripts instead of scenes, that a great news, any chance to get a rough estimation of when you can get this out ? (no pressure, just want to know if I can wait for your solution, or if I need to spend time on a temporary alternative) - Thanks again

DBuit commented 4 years ago

Ah i see i will remove the overflow hidden. There is a change text while go over each other but only for really long names.