Fixes use for browser mod and popup-cards

jimz011 commented 4 years ago

Removed popup-wrapper as this would make it unusable with browser-mod and popup-cards (not entirely sure about popup-cards, but basically they should work the same as browser-mod)
Cleaned up some code (added spaces to some lines to make it uniform to the rest of the file
Added capitalization on the On/Off names (like Apple does it)

FR: Gonna request something as well:

Make border-radius a variable that we can configure (it would be even better if we could use templates for example an input select that has options like 10px, 15px or 20px) but ofc this is maybe a bit too exotic. (still asking anyways XD)
I'd love to use your scenes selector, but I can only configure scenes, if we could configure a hs_color, rgb_color and/or color_temperature that would be amazing. This would save the user the trouble to create scenes to just color the room a single color.

Btw, excellent work. I will feature your card in my videos when I release my project. Thanks again for everything. (I hope one day you will find the time/willingness to look at the thermostat card)

Greetings Jimz011

DBuit commented 4 years ago

Hello Jimz thank for this! You did the changes in the .js file? or in the .ts file in the src directory? Can you do the changes in the .ts file because the .js file is generated from this source.

I also don't think it is very usefull to clean the generated code because it is not done by a human ;) and will change everytime.

DBuit commented 4 years ago

He Jimz i just tested the card with browser_mod popup with this configuration:

popup_cards:
  light.beganegrond:
    title: ""
    style:
      position: fixed
      z-index: 999
      top: 0
      left: 0
      height: 100%
      width: 100%
      display: block
      align-items: center
      justify-content: center
      background: rgba(0, 0, 0, 0.8)
      flex-direction: column
      margin: 0
      "--iron-icon-fill-color": "#FFF"
    card:
      type: custom:light-popup-card
      entity: light.beganegrond
      icon: mdi:led-strip
      scenesInARow: 2
      brightnessWidth: 130px
      brightnessHeight: 350px
      switchWidth: 110px
      switchHeight: 300px
      scenes:
        - scene: scene.ontspannen
          color: "#FDCA64"
          name: ontspannen
        - scene: scene.helder
          color: "#FFE7C0"
          name: helder
        - scene: scene.concentreren
          color: "#BBEEF3"
        - scene: scene.energie
          color: "#8BCBDD"

and it works for me, do you have something different so i can test that?

DBuit commented 4 years ago

im closing this reqeust. in next release stuff will be fixed or can be configured

DBuit / light-popup-card

Fixes use for browser mod and popup-cards #5