search

DBuit / light-popup-card

Lovelace card to use as custom pop-up for light in homekit style
167 stars 38 forks source link

Empty More-info dialog showing when clicking empty space #93

Closed sdrapha closed 2 years ago

sdrapha commented 2 years ago

What is broken

On the current version of HomeAssistant, if you click an empty space of the Light-popup-card, it brings up a new empty more-info popup on top of everything

It doesn't matter if the Light-popup-card is inside a browser-mod popup, or placed directly in the dashboard, with no popup involved whatsoever.

My findings so far

This line from the typescript source code: https://github.com/DBuit/light-popup-card/blob/3543c29b131303bc44b6c6ba874ca307f409b054/src/light-popup-card.ts#L370 Which imports a function of card-tools.

Which eventualy becomes this one on the final JS file: https://github.com/DBuit/light-popup-card/blob/3543c29b131303bc44b6c6ba874ca307f409b054/dist/light-popup-card.js#L3624

It is causing an empty popup showing up on top of everything when you click an empty space of the light-popup-card. Since latest versions of HomeAssistant. Not sure each version in particular started.

I was able to stop the unintended behaviour by commenting out that line.

But I don't know how to actually fix it to actually close a browswer-mod popup as originally intended. That is why I'm not opening a pr. And asking for help, anyone?

sdrapha commented 2 years ago

Commit a8ac5f9 tested. Issue is confirmed fixed. Thanks a lot!