Closed felix-r closed 1 year ago
Base: 91.02% // Head: 90.78% // Decreases project coverage by -0.24%
:warning:
Coverage data is based on head (
620fb24
) compared to base (1a092a8
). Patch coverage: 5.00% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Now that the equations are available on arxiv, I would not write an extensive documentation and rather leave it to you, how to edit the documentation for the new model. Some comments from my side to the notes you have in the docs:
Under the section Viscosity
:
This paragraph is imcomplete:
- Which of the models should one choose? https://github.com/DC-analysis/dclab/issues/197
- How does CellCarrier correspond to which concentration of MC in PBS?
Under the section Büyükurgancı 2022
: I don't think you need to get into all the things you commented there. If you show the Carreau-Yasuda plot, it should become clear how the viscosity behaves. You can also use Figure 3 from the arxiv paper (2023) to illustrate how the viscosity changes depending on temperature, flow rate and channel size.
Do you still want me to add something to the code?
Thanks for the comments. I am currently looking into the arxiv paper and will get back to you if I encounter any issues.
PR to implement new viscosity functions as introduced by Büyükurganci et al.
To do before puling: