search

DC-analysis / dclab

Python library for the post-measurement analysis of real-time deformability cytometry (RT-DC) data sets
https://dclab.readthedocs.io
Other
10 stars 12 forks source link

Do not mark inertia ratio features computed by Shape-in as defective #224

Closed paulmueller closed 1 year ago

paulmueller commented 1 year ago

Shape-In computes inert_ratio_raw and inert_ratio_cvx by default. We should not discard these features.

See also https://github.com/ZELLMECHANIK-DRESDEN/ShapeOut2/issues/139

Note that these features might have been recomputed with dclab and due to #223, dclab versions 0.48.3 (where the check was implemented) through 0.48.8 cannot be trusted. dclab 0.49.0 still discards these features but recomputes them correctly. Only Windows was affected by false feature computation (maybe use that).

paulmueller commented 1 year ago

As far as I can tell, at least Shape-In 2.0.5 already computed inert_ratio_raw and inert_ratio_cvx.

paulmueller commented 1 year ago

Fixed in e19af07.

I did not implement the intermediate check for dclab 0.48.3 through 0.48.8. The bug is a real edge case and anyone encountering it is probably Felix who already updated dclab to 0.49.0.